Re: [Mesa-dev] [PATCH] mesa/program: split reference program into hot/cold paths.

2011-07-13 Thread Dave Airlie
On Wed, Jul 13, 2011 at 4:53 PM, Brian Paul wrote: > On Fri, Jun 24, 2011 at 7:20 AM, Brian Paul wrote: >> On 06/23/2011 11:22 PM, Dave Airlie wrote: >>> >>> From: Dave Airlie >>> >>> inline the hotpath of the reference remaining the same, this shouldn't >>> penalise the slow path at all but impr

Re: [Mesa-dev] [PATCH] mesa/program: split reference program into hot/cold paths.

2011-07-13 Thread Dave Airlie
On Wed, Jul 13, 2011 at 7:26 PM, Brian Paul wrote: > On Wed, Jul 13, 2011 at 12:04 PM, Dave Airlie wrote: >> On Wed, Jul 13, 2011 at 4:53 PM, Brian Paul wrote: > [...] >>> Dave, were you going to commit this patch? >>> >> >> I'm on holidays/moving around the world, so its sitting on my laptop >>

Re: [Mesa-dev] [PATCH] mesa/program: split reference program into hot/cold paths.

2011-07-13 Thread Brian Paul
On Wed, Jul 13, 2011 at 12:04 PM, Dave Airlie wrote: > On Wed, Jul 13, 2011 at 4:53 PM, Brian Paul wrote: [...] >> Dave, were you going to commit this patch? >> > > I'm on holidays/moving around the world, so its sitting on my laptop > here, probably get to it once I start back to work. OK, if y

Re: [Mesa-dev] [PATCH] mesa/program: split reference program into hot/cold paths.

2011-07-13 Thread Brian Paul
On Fri, Jun 24, 2011 at 7:20 AM, Brian Paul wrote: > On 06/23/2011 11:22 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> inline the hotpath of the reference remaining the same, this shouldn't >> penalise the slow path at all but improve the hot path so we don't have >> to jump to the function

Re: [Mesa-dev] [PATCH] mesa/program: split reference program into hot/cold paths.

2011-06-24 Thread Brian Paul
BTW, the same treatment could probably be given to a few other object types, like texture objects and buffer objects. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/program: split reference program into hot/cold paths.

2011-06-24 Thread Brian Paul
On 06/23/2011 11:22 PM, Dave Airlie wrote: From: Dave Airlie inline the hotpath of the reference remaining the same, this shouldn't penalise the slow path at all but improve the hot path so we don't have to jump to the function. It also moves some assert checks under an #ifndef NDEBUG. Signed-

[Mesa-dev] [PATCH] mesa/program: split reference program into hot/cold paths.

2011-06-23 Thread Dave Airlie
From: Dave Airlie inline the hotpath of the reference remaining the same, this shouldn't penalise the slow path at all but improve the hot path so we don't have to jump to the function. It also moves some assert checks under an #ifndef NDEBUG. Signed-off-by: Dave Airlie --- src/mesa/program/p