Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-10 Thread Ilia Mirkin
On Mon, Mar 10, 2014 at 5:44 PM, Ian Romanick wrote: > On 03/04/2014 10:31 AM, Ilia Mirkin wrote: >> On Tue, Mar 4, 2014 at 2:14 AM, Ian Romanick wrote: >>> On 03/02/2014 12:09 AM, Ilia Mirkin wrote: Thought I'd give this a shot. Am I on the right track here? Is the dd API reasonable? I

Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-10 Thread Ian Romanick
On 03/04/2014 10:31 AM, Ilia Mirkin wrote: > On Tue, Mar 4, 2014 at 2:14 AM, Ian Romanick wrote: >> On 03/02/2014 12:09 AM, Ilia Mirkin wrote: >>> >>> This adds enough code to let drivers implement texture clearing, but >>> doesn't actually do that for any of them. >> >> >> There's always the usua

Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-04 Thread Ilia Mirkin
On Tue, Mar 4, 2014 at 2:14 AM, Ian Romanick wrote: > On 03/02/2014 12:09 AM, Ilia Mirkin wrote: >> >> This adds enough code to let drivers implement texture clearing, but >> doesn't actually do that for any of them. > > > There's always the usual... this should be split into two patches. :) > Gen

Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-03 Thread Ian Romanick
On 03/02/2014 12:09 AM, Ilia Mirkin wrote: This adds enough code to let drivers implement texture clearing, but doesn't actually do that for any of them. There's always the usual... this should be split into two patches. :) Generally the changes in gl_API, dispatch_sanity, and "stub" functions

Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-03 Thread Brian Paul
On 03/03/2014 10:52 AM, Ilia Mirkin wrote: On Mon, Mar 3, 2014 at 12:37 PM, Brian Paul wrote: On 03/01/2014 03:09 PM, Ilia Mirkin wrote: This adds enough code to let drivers implement texture clearing, but doesn't actually do that for any of them. Signed-off-by: Ilia Mirkin --- Thought I'd

Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-03 Thread Ilia Mirkin
On Mon, Mar 3, 2014 at 12:37 PM, Brian Paul wrote: > On 03/01/2014 03:09 PM, Ilia Mirkin wrote: >> >> This adds enough code to let drivers implement texture clearing, but >> doesn't actually do that for any of them. >> >> Signed-off-by: Ilia Mirkin >> --- >> >> Thought I'd give this a shot. Am I

Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-03 Thread Brian Paul
On 03/01/2014 03:09 PM, Ilia Mirkin wrote: This adds enough code to let drivers implement texture clearing, but doesn't actually do that for any of them. Signed-off-by: Ilia Mirkin --- Thought I'd give this a shot. Am I on the right track here? Is the dd API reasonable? I haven't written a pig

Re: [Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-01 Thread Andreas Hartmetz
On Saturday 01 March 2014 17:09:58 Ilia Mirkin wrote: > This adds enough code to let drivers implement texture clearing, but > doesn't actually do that for any of them. > > Signed-off-by: Ilia Mirkin > --- > > Thought I'd give this a shot. Am I on the right track here? Is the dd API > reasonable

[Mesa-dev] [PATCH] mesa/main: add ARB_clear_texture entrypoints

2014-03-01 Thread Ilia Mirkin
This adds enough code to let drivers implement texture clearing, but doesn't actually do that for any of them. Signed-off-by: Ilia Mirkin --- Thought I'd give this a shot. Am I on the right track here? Is the dd API reasonable? I haven't written a piglit test for all the "generic" error cases ye