On Sat, Feb 06, 2016 at 01:20:30PM +0100, Kai Wasserbäch wrote:
> Hey Vinson,
> I would say the test is wrong. If I sort as a human, "NV_" comes before
> "NVX_".
>
> And running this through sort (the tool), it agrees:
>
> $ echo -e "NVX_gpu_memory_info\nNV_blend_square" | sort -d
> NV_blend_squ
Reviewed-by: Marek Olšák
On Sat, Feb 6, 2016 at 8:30 AM, Vinson Lee wrote:
> Fixes MesaExtensionsTest.AlphabeticallySorted.
>
> Fixes: 1d79b9958090 ("mesa: implement GL_NVX_gpu_memory_info (v2)")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94016
> Signed-off-by: Vinson Lee
> ---
>
Hey Vinson,
I would say the test is wrong. If I sort as a human, "NV_" comes before "NVX_".
And running this through sort (the tool), it agrees:
$ echo -e "NVX_gpu_memory_info\nNV_blend_square" | sort -d
NV_blend_square
NVX_gpu_memory_info
From src/mesa/main/tests/mesa_extensions.cpp I'm seeing
Fixes MesaExtensionsTest.AlphabeticallySorted.
Fixes: 1d79b9958090 ("mesa: implement GL_NVX_gpu_memory_info (v2)")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94016
Signed-off-by: Vinson Lee
---
src/mesa/main/extensions_table.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)