Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-12 Thread Tapani Pälli
On 10/12/2017 11:14 PM, Dave Airlie wrote: On 12 October 2017 at 18:22, Tapani Pälli wrote: On 10/12/2017 11:14 AM, Dave Airlie wrote: On 12 Oct. 2017 15:40, "Tapani Pälli" mailto:tapani.pa...@intel.com>> wrote: On 10/12/2017 02:34 AM, Dave Airlie wrote: From: Dave Airl

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-12 Thread Dave Airlie
On 12 October 2017 at 18:22, Tapani Pälli wrote: > > > On 10/12/2017 11:14 AM, Dave Airlie wrote: >> >> >> On 12 Oct. 2017 15:40, "Tapani Pälli" > > wrote: >> >> >> >> On 10/12/2017 02:34 AM, Dave Airlie wrote: >> >> From: Dave Airlie mailto:airl...@redha

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-12 Thread Mark Janes
Tested-by: Mark Janes Dave Airlie writes: > From: Dave Airlie > > When I realigned the bufferobj code, I didn't see the getters > were different, realign the getters to work the same as ssbo. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103214 > Fixes: 65d3ef7cd (mesa: align atom

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-12 Thread Tapani Pälli
On 10/12/2017 11:14 AM, Dave Airlie wrote: On 12 Oct. 2017 15:40, "Tapani Pälli" > wrote: On 10/12/2017 02:34 AM, Dave Airlie wrote: From: Dave Airlie mailto:airl...@redhat.com>> When I realigned the bufferobj code, I didn't see the gett

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-12 Thread Dave Airlie
On 12 Oct. 2017 15:40, "Tapani Pälli" wrote: On 10/12/2017 02:34 AM, Dave Airlie wrote: > From: Dave Airlie > > When I realigned the bufferobj code, I didn't see the getters > were different, realign the getters to work the same as ssbo. > Alternatively you could set these values as 0 in bin

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-12 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/12/2017 01:34 AM, Dave Airlie wrote: From: Dave Airlie When I realigned the bufferobj code, I didn't see the getters were different, realign the getters to work the same as ssbo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103214 Fixes: 65d3ef7cd

Re: [Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-11 Thread Tapani Pälli
On 10/12/2017 02:34 AM, Dave Airlie wrote: From: Dave Airlie When I realigned the bufferobj code, I didn't see the getters were different, realign the getters to work the same as ssbo. Alternatively you could set these values as 0 in bind_buffer_base_atomic_buffer()? Not sure if it's any b

[Mesa-dev] [PATCH] mesa/bufferobj: fix atomic offset/size get

2017-10-11 Thread Dave Airlie
From: Dave Airlie When I realigned the bufferobj code, I didn't see the getters were different, realign the getters to work the same as ssbo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103214 Fixes: 65d3ef7cd (mesa: align atomic buffer handling code with ubo/ssbo (v1.1)) Signed-off-b