Re: [Mesa-dev] [PATCH] mapi: Fix tls with shared/es-glapi on x86-64

2011-06-12 Thread Benjamin Franzke
2011/6/11 Chia-I Wu : > I got this warning after applying the patch > >  ../../../src/mapi/mapi/entry_x86-64_tls.h:69:1: warning: > ‘x86_64_current_tls’ used but never defined > > Maybe the function declaration should be decorated with "extern"? Yeah, should work at least, just checked that caling

Re: [Mesa-dev] [PATCH] mapi: Fix tls with shared/es-glapi on x86-64

2011-06-10 Thread Chia-I Wu
On Wed, Jun 8, 2011 at 10:07 PM, Benjamin Franzke wrote: > 2011/6/7 Chia-I Wu : >> How is that the case?  It seems the symbol is not used elsewhere. >> > > Right, seems i tried solve the wrong side of the problem. > > x86_64_entry_start is declared similar to a global static variable in > the asm

Re: [Mesa-dev] [PATCH] mapi: Fix tls with shared/es-glapi on x86-64

2011-06-08 Thread Benjamin Franzke
2011/6/7 Chia-I Wu : > How is that the case?  It seems the symbol is not used elsewhere. > Right, seems i tried solve the wrong side of the problem. x86_64_entry_start is declared similar to a global static variable in the asm code, so it will be bound local. But in entry_get_public its declared

Re: [Mesa-dev] [PATCH] mapi: Fix tls with shared/es-glapi on x86-64

2011-06-07 Thread Chia-I Wu
On Wed, Jun 8, 2011 at 2:33 AM, Benjamin Franzke wrote: > x86_64_entry_start needs to be bound global, in order to have the > correct address in entry_get_public (seems not to be needed on x86). > > Otherwise addresses needed for _glapi_proc_address will be computed > from some random offset (0x64

[Mesa-dev] [PATCH] mapi: Fix tls with shared/es-glapi on x86-64

2011-06-07 Thread Benjamin Franzke
x86_64_entry_start needs to be bound global, in order to have the correct address in entry_get_public (seems not to be needed on x86). Otherwise addresses needed for _glapi_proc_address will be computed from some random offset (0x6400229a61058b48 in my case). --- src/mapi/mapi/entry_x86-64_tls.h