Re: [Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

2015-04-01 Thread Laura Ekstrand
Hmm, I don't trust myself with gotos yet because I still don't have much experience writing them. So maybe I'll use them for a different patch later. On Wed, Apr 1, 2015 at 11:56 AM, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > An alternative, btw, is to do a goto to the existing unlock.

Re: [Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

2015-04-01 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin An alternative, btw, is to do a goto to the existing unlock. This would have the advantage of keeping a single unlock, and a single return path in the function. Your call, you get the R-b either way. -ilia On Wed, Apr 1, 2015 at 2:23 PM, Laura Ekstrand wrote: > Ilia

[Mesa-dev] [PATCH] main: create_buffers unlocks mutex when throwing OUT_OF_MEMORY.

2015-04-01 Thread Laura Ekstrand
Ilia Mirkin found that I had forgotten to free the mutex in the error case. --- src/mesa/main/bufferobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b67e1c4..c7ef90b 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/buff