Re: [Mesa-dev] [PATCH] loader: include for non-sysfs builds

2015-03-11 Thread Emil Velikov
On 11 March 2015 at 22:18, Ian Romanick wrote: > On 03/11/2015 02:44 PM, Emil Velikov wrote: >> On 11 March 2015 at 20:50, Ian Romanick wrote: >>> On 03/11/2015 12:12 PM, Emil Velikov wrote: Required by fstat(), otherwise we'll error out due to implicit function declaration. >>> >>> Alt

Re: [Mesa-dev] [PATCH] loader: include for non-sysfs builds

2015-03-11 Thread Ian Romanick
On 03/11/2015 02:44 PM, Emil Velikov wrote: > On 11 March 2015 at 20:50, Ian Romanick wrote: >> On 03/11/2015 12:12 PM, Emil Velikov wrote: >>> Required by fstat(), otherwise we'll error out due to implicit function >>> declaration. >> >> Alternate suggestion... include unistd.h unconditionally.

Re: [Mesa-dev] [PATCH] loader: include for non-sysfs builds

2015-03-11 Thread Emil Velikov
On 11 March 2015 at 20:50, Ian Romanick wrote: > On 03/11/2015 12:12 PM, Emil Velikov wrote: >> Required by fstat(), otherwise we'll error out due to implicit function >> declaration. > > Alternate suggestion... include unistd.h unconditionally. I see that's > already in the #ifdef HAVE_LIBUDEV p

Re: [Mesa-dev] [PATCH] loader: include for non-sysfs builds

2015-03-11 Thread Ian Romanick
On 03/11/2015 12:12 PM, Emil Velikov wrote: > Required by fstat(), otherwise we'll error out due to implicit function > declaration. Alternate suggestion... include unistd.h unconditionally. I see that's already in the #ifdef HAVE_LIBUDEV path. Does that work too? > Cc: "10.4 10.5" > Bugzilla:

[Mesa-dev] [PATCH] loader: include for non-sysfs builds

2015-03-11 Thread Emil Velikov
Required by fstat(), otherwise we'll error out due to implicit function declaration. Cc: "10.4 10.5" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89530 Signed-off-by: Emil Velikov --- src/loader/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loader/lo