Re: [Mesa-dev] [PATCH] loader: fix the no-modifiers case

2019-01-22 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Jan 22, 2019 at 10:20 PM Kristian Høgsberg wrote: > > On Tue, Jan 22, 2019 at 11:45 AM Rob Clark wrote: > > > > Normally modifiers take precendence over use flags, as they are more > > explicit. But if the driver supports modifiers, but the xserver does >

Re: [Mesa-dev] [PATCH] loader: fix the no-modifiers case

2019-01-22 Thread Kristian Høgsberg
On Tue, Jan 22, 2019 at 11:45 AM Rob Clark wrote: > > Normally modifiers take precendence over use flags, as they are more > explicit. But if the driver supports modifiers, but the xserver does > not, then we should fallback to the old mechanism of allocating a buffer > using 'use' flags. > > Fix

[Mesa-dev] [PATCH] loader: fix the no-modifiers case

2019-01-22 Thread Rob Clark
Normally modifiers take precendence over use flags, as they are more explicit. But if the driver supports modifiers, but the xserver does not, then we should fallback to the old mechanism of allocating a buffer using 'use' flags. Fixes: 069fdd5f9facbd72fb6a289696c7b74e3237e70f Signed-off-by: Rob