Re: [Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

2014-01-30 Thread Kristian Høgsberg
On Thu, Jan 30, 2014 at 12:20 AM, Stéphane Marchesin wrote: > > > > On Thu, Jan 30, 2014 at 12:07 AM, Eric Anholt wrote: >> >> Stéphane Marchesin writes: >> >> > On systems without libudev, the loader_get_pci_id_for_fd() call will >> > return 0, which will trigger the drmGetVersion logic. Sadly,

Re: [Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

2014-01-30 Thread Lauri Kasanen
On Wed, 29 Jan 2014 17:33:23 -0800 Stéphane Marchesin wrote: > On systems without libudev, the loader_get_pci_id_for_fd() call will > return 0, which will trigger the drmGetVersion logic. Sadly, this > logic assumes that the kernel driver name matches the dri driver name, > which is not the case

Re: [Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

2014-01-30 Thread Stéphane Marchesin
On Thu, Jan 30, 2014 at 12:20 AM, Stéphane Marchesin < stephane.marche...@gmail.com> wrote: > > > > On Thu, Jan 30, 2014 at 12:07 AM, Eric Anholt wrote: > >> Stéphane Marchesin writes: >> >> > On systems without libudev, the loader_get_pci_id_for_fd() call will >> > return 0, which will trigger

Re: [Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

2014-01-30 Thread Stéphane Marchesin
On Thu, Jan 30, 2014 at 12:07 AM, Eric Anholt wrote: > Stéphane Marchesin writes: > > > On systems without libudev, the loader_get_pci_id_for_fd() call will > > return 0, which will trigger the drmGetVersion logic. Sadly, this > > logic assumes that the kernel driver name matches the dri driver

Re: [Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

2014-01-30 Thread Eric Anholt
Stéphane Marchesin writes: > On systems without libudev, the loader_get_pci_id_for_fd() call will > return 0, which will trigger the drmGetVersion logic. Sadly, this > logic assumes that the kernel driver name matches the dri driver name, > which is not the case on recent intel GPUs (for example

[Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

2014-01-29 Thread Stéphane Marchesin
On systems without libudev, the loader_get_pci_id_for_fd() call will return 0, which will trigger the drmGetVersion logic. Sadly, this logic assumes that the kernel driver name matches the dri driver name, which is not the case on recent intel GPUs (for example i965 dri driver and i915 kernel modul