Re: [Mesa-dev] [PATCH] llvmpipe: improve rasterization discard logic

2018-05-22 Thread Roland Scheidegger
Am 22.05.2018 um 05:01 schrieb Brian Paul: > On 05/21/2018 07:34 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> This unifies the explicit rasterization dicard as well as the implicit > > "discard" Right. > > Looks OK to me.  Minor nits below. > > Reviewed-by: Brian Paul > >

Re: [Mesa-dev] [PATCH] llvmpipe: improve rasterization discard logic

2018-05-21 Thread Brian Paul
On 05/21/2018 07:34 PM, srol...@vmware.com wrote: From: Roland Scheidegger This unifies the explicit rasterization dicard as well as the implicit "discard" Looks OK to me. Minor nits below. Reviewed-by: Brian Paul rasterization disabled logic (which we need for another state tracker),

[Mesa-dev] [PATCH] llvmpipe: improve rasterization discard logic

2018-05-21 Thread sroland
From: Roland Scheidegger This unifies the explicit rasterization dicard as well as the implicit rasterization disabled logic (which we need for another state tracker), which really should do the exact same thing. We'll now toss out the prims early on in setup with (implicit or explicit) discard,