Re: [Mesa-dev] [PATCH] llvmpipe: handle offset_clamp

2013-06-27 Thread Roland Scheidegger
Am 27.06.2013 09:41, schrieb Jose Fonseca: > - Original Message - >> From: Roland Scheidegger >> >> This was just ignored (unless for some reason like unfilled polys draw was >> handling this). > > Patch looks good. > >> I'm not convinced of that code, putting the float for the clamp in

Re: [Mesa-dev] [PATCH] llvmpipe: handle offset_clamp

2013-06-27 Thread Jose Fonseca
- Original Message - > From: Roland Scheidegger > > This was just ignored (unless for some reason like unfilled polys draw was > handling this). Patch looks good. > I'm not convinced of that code, putting the float for the clamp in the key > isn't really a good idea. Indeed. > Then a

[Mesa-dev] [PATCH] llvmpipe: handle offset_clamp

2013-06-26 Thread sroland
From: Roland Scheidegger This was just ignored (unless for some reason like unfilled polys draw was handling this). I'm not convinced of that code, putting the float for the clamp in the key isn't really a good idea. Then again the other floats for depth bias are already in there too anyway (shou