Re: [Mesa-dev] [PATCH] llvmpipe: fix snorm blending

2017-11-20 Thread Roland Scheidegger
Am 20.11.2017 um 14:58 schrieb Jose Fonseca: > On 18/11/17 05:34, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The blend math gets a bit funky due to inverse blend factors being >> in range [0,2] rather than [-1,1], our normalized math can't really >> cover this. >> src_alpha_satura

Re: [Mesa-dev] [PATCH] llvmpipe: fix snorm blending

2017-11-20 Thread Jose Fonseca
On 18/11/17 05:34, srol...@vmware.com wrote: From: Roland Scheidegger The blend math gets a bit funky due to inverse blend factors being in range [0,2] rather than [-1,1], our normalized math can't really cover this. src_alpha_saturate blend factor has a similar problem too. (Note that piglit f

[Mesa-dev] [PATCH] llvmpipe: fix snorm blending

2017-11-17 Thread sroland
From: Roland Scheidegger The blend math gets a bit funky due to inverse blend factors being in range [0,2] rather than [-1,1], our normalized math can't really cover this. src_alpha_saturate blend factor has a similar problem too. (Note that piglit fbo-blending-formats test is mostly useless for

Re: [Mesa-dev] [PATCH] llvmpipe: fix snorm blending

2017-11-17 Thread Roland Scheidegger
Am 17.11.2017 um 14:20 schrieb Emil Velikov: > Hi Roland, > > Just a small fly-by idea: > > On 17 November 2017 at 07:00, wrote: > >> - if(bld->type.norm) { >> + if(type.norm) { >>const char *intrinsic = NULL; >> >> - if(a == bld->one || b == bld->one) >> + if(!type.sign

Re: [Mesa-dev] [PATCH] llvmpipe: fix snorm blending

2017-11-17 Thread Emil Velikov
Hi Roland, Just a small fly-by idea: On 17 November 2017 at 07:00, wrote: > - if(bld->type.norm) { > + if(type.norm) { >const char *intrinsic = NULL; > > - if(a == bld->one || b == bld->one) > + if(!type.sign && (a == bld->one || b == bld->one)) > return bld->one

[Mesa-dev] [PATCH] llvmpipe: fix snorm blending

2017-11-16 Thread sroland
From: Roland Scheidegger The blend math gets a bit funky due to inverse blend factors being in range [0,2] rather than [-1,1], our normalized math can't really cover this. src_alpha_saturate blend factor has a similar problem too. (Note that piglit fbo-blending-formats test is mostly useless for