Re: [Mesa-dev] [PATCH] llvmpipe: fix arguments order given to vec_andc

2016-01-17 Thread Roland Scheidegger
Am 17.01.2016 um 14:31 schrieb Oded Gabbay: > This patch fixes a classic "confuse the enemy" bug. > > _mm_andnot_si128 (SSE) and vec_andc (VMX) do the same operation, but the > arguments are opposite. > > _mm_andnot_si128 performs "r = (~a) & b" while > vec_andc performs "r = a & (~b)" > > To ma

[Mesa-dev] [PATCH] llvmpipe: fix arguments order given to vec_andc

2016-01-17 Thread Oded Gabbay
This patch fixes a classic "confuse the enemy" bug. _mm_andnot_si128 (SSE) and vec_andc (VMX) do the same operation, but the arguments are opposite. _mm_andnot_si128 performs "r = (~a) & b" while vec_andc performs "r = a & (~b)" To make sure this error won't return in another place, I added a wr