Re: [Mesa-dev] [PATCH] llvmpipe: Fix random number generation for unit tests

2018-05-14 Thread Jose Fonseca
Hi Roland, It's indeed been long time since I wrote this and I'm no longer certain of what I intended to do, but the change looks overall. Reviewed-by: Jose Fonseca But is it really true rand returns 63 bits? I think it return RAND_MAX, which was actually often 31 bits. Perhaps we should ad

[Mesa-dev] [PATCH] llvmpipe: Fix random number generation for unit tests

2018-05-07 Thread sroland
From: Roland Scheidegger We were never producing negative numbers for signed types. Also fix only producing half the valid range for uint32, and properly clamp signed values. Because this now also properly tests snorm with actually negative values, need to increase eps for such conversions. I be