Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-27 Thread Roland Scheidegger
Am 28.06.2011 00:12, schrieb Ian Romanick: > On 06/23/2011 07:56 AM, Alex Deucher wrote: >> On Thu, Jun 23, 2011 at 10:38 AM, Roland Scheidegger >> wrote: >>> Am 23.06.2011 16:09, schrieb Jerome Glisse: On Wed, Jun 22, 2011 at 10:49 PM, Alex Deucher wrote: > On Wed, Jun 22, 2011 a

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-27 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/23/2011 07:56 AM, Alex Deucher wrote: > On Thu, Jun 23, 2011 at 10:38 AM, Roland Scheidegger > wrote: >> Am 23.06.2011 16:09, schrieb Jerome Glisse: >>> On Wed, Jun 22, 2011 at 10:49 PM, Alex Deucher >>> wrote: On Wed, Jun 22, 2011 at 10

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-23 Thread Christoph Bumiller
On 23.06.2011 04:12, Roland Scheidegger wrote: > Am 21.06.2011 20:59, schrieb Sven Arvidsson: >> This change broke a whole lot of stuff on r600g, for example Unigine >> Heaven: >> >> shader uses too many varying components (36 > 32) > It looks like the r600g driver claims to only support 10 va

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-23 Thread Alex Deucher
On Thu, Jun 23, 2011 at 10:38 AM, Roland Scheidegger wrote: > Am 23.06.2011 16:09, schrieb Jerome Glisse: >> On Wed, Jun 22, 2011 at 10:49 PM, Alex Deucher wrote: >>> On Wed, Jun 22, 2011 at 10:12 PM, Roland Scheidegger >>> wrote: Am 21.06.2011 20:59, schrieb Sven Arvidsson: > This cha

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-23 Thread Jerome Glisse
On Thu, Jun 23, 2011 at 10:38 AM, Roland Scheidegger wrote: > Am 23.06.2011 16:09, schrieb Jerome Glisse: >> On Wed, Jun 22, 2011 at 10:49 PM, Alex Deucher wrote: >>> On Wed, Jun 22, 2011 at 10:12 PM, Roland Scheidegger >>> wrote: Am 21.06.2011 20:59, schrieb Sven Arvidsson: > This cha

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-23 Thread Roland Scheidegger
Am 23.06.2011 16:09, schrieb Jerome Glisse: > On Wed, Jun 22, 2011 at 10:49 PM, Alex Deucher wrote: >> On Wed, Jun 22, 2011 at 10:12 PM, Roland Scheidegger >> wrote: >>> Am 21.06.2011 20:59, schrieb Sven Arvidsson: This change broke a whole lot of stuff on r600g, for example Unigine He

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-23 Thread Jerome Glisse
On Wed, Jun 22, 2011 at 10:49 PM, Alex Deucher wrote: > On Wed, Jun 22, 2011 at 10:12 PM, Roland Scheidegger > wrote: >> Am 21.06.2011 20:59, schrieb Sven Arvidsson: >>> This change broke a whole lot of stuff on r600g, for example Unigine >>> Heaven: >>> >>>       shader uses too many varying co

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-22 Thread Alex Deucher
On Wed, Jun 22, 2011 at 10:12 PM, Roland Scheidegger wrote: > Am 21.06.2011 20:59, schrieb Sven Arvidsson: >> This change broke a whole lot of stuff on r600g, for example Unigine >> Heaven: >> >>       shader uses too many varying components (36 > 32) > > It looks like the r600g driver claims to o

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-22 Thread Roland Scheidegger
Am 21.06.2011 20:59, schrieb Sven Arvidsson: > This change broke a whole lot of stuff on r600g, for example Unigine > Heaven: > > shader uses too many varying components (36 > 32) It looks like the r600g driver claims to only support 10 varyings, which the state tracker reduces to 8 (as it

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-21 Thread Sven Arvidsson
This change broke a whole lot of stuff on r600g, for example Unigine Heaven: shader uses too many varying components (36 > 32) I was going to attach the failing shader but it doesn't seem to have been logged by MESA_GLSL=log -- Cheers, Sven Arvidsson http://www.whiz.se PGP Key ID 760BDD

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-13 Thread Eric Anholt
On Mon, 13 Jun 2011 12:09:04 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > Previously it was up to the driver or later code generator to reject > these shaders. It turns out that nobody did this. > > This will need changes to support geometry shaders. > > NOTE: This is a candidate for

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-13 Thread Tilman Sauerbeck
Ian Romanick [2011-06-13 12:09]: > [...] > + } else if (var->type->is_matrix()) { > + varying_vectors += var->type->matrix_columns; > + float_components += var->type->matrix_columns * 4; > + } else { > + varying_vectors++; > + float_components += var->type

[Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-13 Thread Ian Romanick
From: Ian Romanick Previously it was up to the driver or later code generator to reject these shaders. It turns out that nobody did this. This will need changes to support geometry shaders. NOTE: This is a candidate for the stable branches. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?