Re: [Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

2017-02-23 Thread Jason Ekstrand
On Feb 22, 2017 11:17 PM, "Samuel Iglesias Gonsálvez" wrote: On 22/02/17 17:32, Jason Ekstrand wrote: > Seems reasonable Are you sure this isn't somehow required on old hardware? > This assert is inside if (gen >= 7) block. I have checked all gen7+ specs and they all say the same. What I saw

Re: [Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

2017-02-22 Thread Samuel Iglesias Gonsálvez
On 22/02/17 17:32, Jason Ekstrand wrote: > Seems reasonable Are you sure this isn't somehow required on old hardware? > This assert is inside if (gen >= 7) block. I have checked all gen7+ specs and they all say the same. What I saw was that for PLANAR* surface formats, num_elements must be a

Re: [Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

2017-02-22 Thread Jason Ekstrand
Seems reasonable Are you sure this isn't somehow required on old hardware? Reviewed-by: Jason Ekstrand On Wed, Feb 22, 2017 at 3:39 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From IVB PRM, SURFACE_STATE::Height: > > "For typed buffer and structured buffer surfaces, the numb

[Mesa-dev] [PATCH] isl/state: fix assert on raw buffer surface state minimum size

2017-02-22 Thread Samuel Iglesias Gonsálvez
From IVB PRM, SURFACE_STATE::Height: "For typed buffer and structured buffer surfaces, the number of entries in the buffer ranges from 1 to 2^27 . For raw buffer surfaces, the number of entries in the buffer is the number of bytes which can range from 1 to 2^30." The minimum value is 1, accord