Re: [Mesa-dev] [PATCH] intel: Fix 3DSTATE_CONSTANT buffer decoding.

2018-05-02 Thread Kenneth Graunke
On Wednesday, May 2, 2018 9:50:33 AM PDT Lionel Landwerlin wrote: > On 02/05/18 17:45, Kenneth Graunke wrote: > > First, this was iterating over the 3DSTATE_CONSTANT_* instruction > > but trying to process fields of the 3DSTATE_CONSTANT_BODY substructure. > > > > Secondly, the fields have been call

Re: [Mesa-dev] [PATCH] intel: Fix 3DSTATE_CONSTANT buffer decoding.

2018-05-02 Thread Lionel Landwerlin
On 02/05/18 17:45, Kenneth Graunke wrote: First, this was iterating over the 3DSTATE_CONSTANT_* instruction but trying to process fields of the 3DSTATE_CONSTANT_BODY substructure. Secondly, the fields have been called Buffer[0] and Read Length[0], for a while now, and we were not handling the su

[Mesa-dev] [PATCH] intel: Fix 3DSTATE_CONSTANT buffer decoding.

2018-05-02 Thread Kenneth Graunke
First, this was iterating over the 3DSTATE_CONSTANT_* instruction but trying to process fields of the 3DSTATE_CONSTANT_BODY substructure. Secondly, the fields have been called Buffer[0] and Read Length[0], for a while now, and we were not handling the subscripts correctly. --- src/intel/common/ge