Re: [Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-10-02 Thread Jason Ekstrand
I'd personally separate the XML changes from the is changes but I don't care that much. Either way, r-b me. On October 2, 2017 3:49:16 PM Kenneth Graunke wrote: These shouldn't matter for non-cubes, and we always enable them all for cubes, so we may as well set them all the time. While we'

Re: [Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-10-02 Thread Matt Turner
Looks good to me. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-10-02 Thread Kenneth Graunke
These shouldn't matter for non-cubes, and we always enable them all for cubes, so we may as well set them all the time. While we're at it, let's make the genxml fields consistent. We pick the boolean-per-face approach because it's clear which bits correspond to which cube faces. v2: Don't use "m

Re: [Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-09-30 Thread Jason Ekstrand
On September 30, 2017 12:29:56 AM Matt Turner wrote: On Fri, Sep 29, 2017 at 10:54 PM, Kenneth Graunke wrote: These shouldn't matter for non-cubes, and we always enable them all for cubes, so we may as well set them all the time. We can just mark the fields "mbo" (must be one) and genxml wil

Re: [Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-09-30 Thread Matt Turner
On Fri, Sep 29, 2017 at 10:54 PM, Kenneth Graunke wrote: > These shouldn't matter for non-cubes, and we always enable them all > for cubes, so we may as well set them all the time. We can just mark > the fields "mbo" (must be one) and genxml will automatically set them > for us, and we never even

[Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-09-29 Thread Kenneth Graunke
These shouldn't matter for non-cubes, and we always enable them all for cubes, so we may as well set them all the time. We can just mark the fields "mbo" (must be one) and genxml will automatically set them for us, and we never even have to think about them. --- src/intel/genxml/gen10.xml