Re: [Mesa-dev] [PATCH] intel/fs: Get rid of fs_inst::equals

2019-01-27 Thread Iago Toral
On Fri, 2019-01-25 at 15:47 -0600, Jason Ekstrand wrote: > There are piles of fields that it doesn't check so using it is a lie. > The only reason why it's not causing problem is because it has > exactly > one user which only uses it for MOV instructions (which aren't very > interesting) and only o

[Mesa-dev] [PATCH] intel/fs: Get rid of fs_inst::equals

2019-01-25 Thread Jason Ekstrand
There are piles of fields that it doesn't check so using it is a lie. The only reason why it's not causing problem is because it has exactly one user which only uses it for MOV instructions (which aren't very interesting) and only on Sandy Bridge and earlier hardware. Just get rid of it and inline

[Mesa-dev] [PATCH] intel/fs: Get rid of fs_inst::equals

2019-01-25 Thread Jason Ekstrand
There are piles of fields that it doesn't check so using it is a lie. The only reason why it's not causing problem is because it has exactly one user which only uses it for MOV instructions (which aren't very interesting) and only on Sandy Bridge and earlier hardware. Just get rid of it and inline