[Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access (v3)

2013-05-30 Thread Dave Airlie
Okay I now understand why Frank would want to run away, this is my attempt at fixing the CVE out of bounds access to constants outside the range. This attempt converts any illegal constants to constant 0 as per the GL spec, and is undefined behaviour. A future patch should add some debug for users

Re: [Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access (v2)

2013-05-30 Thread Dave Airlie
On Thu, May 30, 2013 at 4:35 PM, Kenneth Graunke wrote: > On 05/29/2013 05:44 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This is my attempt at fixing this as the CVE is making RH security team >> care enough to make me look at this. (please upstream, security fixes are >> more important

Re: [Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access (v2)

2013-05-29 Thread Kenneth Graunke
On 05/29/2013 05:44 PM, Dave Airlie wrote: From: Dave Airlie This is my attempt at fixing this as the CVE is making RH security team care enough to make me look at this. (please upstream, security fixes are more important than whatever else you are doing, if for no other reason than it saves me

Re: [Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access

2013-05-29 Thread Ian Romanick
On 05/29/2013 04:54 PM, Dave Airlie wrote: From: Dave Airlie This is my attempt at fixing this as the CVE is making RH security team care enough to make me look at this. (please upstream, security fixes are more important than whatever else you are doing, if for no other reason than it saves me

Re: [Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access (v2)

2013-05-29 Thread Kenneth Graunke
On 05/29/2013 05:44 PM, Dave Airlie wrote: From: Dave Airlie This is my attempt at fixing this as the CVE is making RH security team care enough to make me look at this. (please upstream, security fixes are more important than whatever else you are doing, if for no other reason than it saves me

[Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access (v2)

2013-05-29 Thread Dave Airlie
From: Dave Airlie This is my attempt at fixing this as the CVE is making RH security team care enough to make me look at this. (please upstream, security fixes are more important than whatever else you are doing, if for no other reason than it saves me having to fix stuff I've no real clue about)

Re: [Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access

2013-05-29 Thread Dave Airlie
On Thu, May 30, 2013 at 10:21 AM, Eric Anholt wrote: > Dave Airlie writes: > >> From: Dave Airlie >> >> This is my attempt at fixing this as the CVE is making RH security team >> care enough to make me look at this. (please upstream, security fixes are >> more important than whatever else you ar

Re: [Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access

2013-05-29 Thread Eric Anholt
Dave Airlie writes: > From: Dave Airlie > > This is my attempt at fixing this as the CVE is making RH security team > care enough to make me look at this. (please upstream, security fixes are > more important than whatever else you are doing, if for no other reason than > it saves me having to f

[Mesa-dev] [PATCH] i965: fix problem with constant out of bounds access

2013-05-29 Thread Dave Airlie
From: Dave Airlie This is my attempt at fixing this as the CVE is making RH security team care enough to make me look at this. (please upstream, security fixes are more important than whatever else you are doing, if for no other reason than it saves me having to fix stuff I've no real clue about)