Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-11-01 Thread Timothy Arceri
On 1 November 2016 6:00:46 pm AEDT, Timothy Arceri wrote: >On Tue, 2016-11-01 at 08:06 +0200, Tapani Pälli wrote: >> >> On 10/29/2016 03:29 AM, Kenneth Graunke wrote: >> > >> > On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote: >> > > >> > > On 10/28/2016 05:15 AM, Timothy Arcer

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-11-01 Thread Timothy Arceri
On Tue, 2016-11-01 at 08:06 +0200, Tapani Pälli wrote: > > On 10/29/2016 03:29 AM, Kenneth Graunke wrote: > > > > On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote: > > > > > > On 10/28/2016 05:15 AM, Timothy Arceri wrote: > > > > > > > > On Thu, 2016-10-27 at 18:51 -0700, Kenneth

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-31 Thread Tapani Pälli
On 10/29/2016 03:29 AM, Kenneth Graunke wrote: On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote: On 10/28/2016 05:15 AM, Timothy Arceri wrote: On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote: On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: On Thu, 2

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-28 Thread Kenneth Graunke
On Friday, October 28, 2016 10:39:01 AM PDT Tapani Pälli wrote: > On 10/28/2016 05:15 AM, Timothy Arceri wrote: > > On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote: > >> On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: > >>> On Thu, 2016-10-27 at 12:37 +1100, Timothy Arce

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-28 Thread Tapani Pälli
On 10/28/2016 05:15 AM, Timothy Arceri wrote: On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote: On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: Agreed but as far as I can tell we shouldn't even need gl_linked_s

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-27 Thread Timothy Arceri
On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote: > On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: > > > > On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: > > > > > > Agreed but as far as I can tell we shouldn't even need > > > gl_linked_shader > > > after glL

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-27 Thread Kenneth Graunke
On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: > On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: > > Agreed but as far as I can tell we shouldn't even need > > gl_linked_shader > > after glLinkProgram. > > > > We should probably just free it after linking. Everything w

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-27 Thread Timothy Arceri
On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: > On Wed, 2016-10-26 at 20:19 -0400, Ilia Mirkin wrote: > > > > On Wed, Oct 26, 2016 at 8:08 PM, Timothy Arceri > > wrote: > > > > > > > > > On Wed, 2016-10-26 at 22:51 +1100, Timothy Arceri wrote: > > > > > > > > > > > > On Wed, 2016-1

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-26 Thread Timothy Arceri
On Wed, 2016-10-26 at 20:19 -0400, Ilia Mirkin wrote: > On Wed, Oct 26, 2016 at 8:08 PM, Timothy Arceri > wrote: > > > > On Wed, 2016-10-26 at 22:51 +1100, Timothy Arceri wrote: > > > > > > On Wed, 2016-10-26 at 13:13 +0300, Tapani Pälli wrote: > > > > > > > > > > > > Hi; > > > > > > > > On 1

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-26 Thread Ilia Mirkin
On Wed, Oct 26, 2016 at 8:08 PM, Timothy Arceri wrote: > On Wed, 2016-10-26 at 22:51 +1100, Timothy Arceri wrote: >> On Wed, 2016-10-26 at 13:13 +0300, Tapani Pälli wrote: >> > >> > Hi; >> > >> > On 10/26/2016 11:27 AM, Tapani Pälli wrote: >> > > >> > > >> > > >> > > >> > > On 10/26/2016 11:21 AM,

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-26 Thread Timothy Arceri
On Wed, 2016-10-26 at 22:51 +1100, Timothy Arceri wrote: > On Wed, 2016-10-26 at 13:13 +0300, Tapani Pälli wrote: > > > > Hi; > > > > On 10/26/2016 11:27 AM, Tapani Pälli wrote: > > > > > > > > > > > > > > > On 10/26/2016 11:21 AM, Timothy Arceri wrote: > > > > > > > > > > > > On Wed, 2016-

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-26 Thread Timothy Arceri
On Wed, 2016-10-26 at 13:13 +0300, Tapani Pälli wrote: > Hi; > > On 10/26/2016 11:27 AM, Tapani Pälli wrote: > > > > > > > > On 10/26/2016 11:21 AM, Timothy Arceri wrote: > > > > > > On Wed, 2016-10-26 at 08:50 +0300, Tapani Pälli wrote: > > > > > > > > > > > > On 10/26/2016 08:15 AM, Timoth

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-26 Thread Tapani Pälli
Hi; On 10/26/2016 11:27 AM, Tapani Pälli wrote: On 10/26/2016 11:21 AM, Timothy Arceri wrote: On Wed, 2016-10-26 at 08:50 +0300, Tapani Pälli wrote: On 10/26/2016 08:15 AM, Timothy Arceri wrote: On Tue, 2016-10-25 at 09:39 +0300, Tapani Pälli wrote: SSO shader programs can be later modi

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-26 Thread Tapani Pälli
On 10/26/2016 11:21 AM, Timothy Arceri wrote: On Wed, 2016-10-26 at 08:50 +0300, Tapani Pälli wrote: On 10/26/2016 08:15 AM, Timothy Arceri wrote: On Tue, 2016-10-25 at 09:39 +0300, Tapani Pälli wrote: SSO shader programs can be later modified by attaching/detaching shaders and relinked,

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-26 Thread Timothy Arceri
On Wed, 2016-10-26 at 08:50 +0300, Tapani Pälli wrote: > > On 10/26/2016 08:15 AM, Timothy Arceri wrote: > > > > On Tue, 2016-10-25 at 09:39 +0300, Tapani Pälli wrote: > > > > > > SSO shader programs can be later modified by attaching/detaching > > > shaders and relinked, this requires IR. > >

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-25 Thread Tapani Pälli
On 10/26/2016 08:15 AM, Timothy Arceri wrote: On Tue, 2016-10-25 at 09:39 +0300, Tapani Pälli wrote: SSO shader programs can be later modified by attaching/detaching shaders and relinked, this requires IR. Doesn't relinking recreate the IR? We can relink exiting shaders into new programs. Th

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-25 Thread Timothy Arceri
On Tue, 2016-10-25 at 09:39 +0300, Tapani Pälli wrote: > SSO shader programs can be later modified by attaching/detaching > shaders and relinked, this requires IR. Doesn't relinking recreate the IR? We can relink exiting shaders into new programs. The IR is cloned from gl_shader (the compiled IR)

[Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

2016-10-24 Thread Tapani Pälli
SSO shader programs can be later modified by attaching/detaching shaders and relinked, this requires IR. This patch fixes regression caused by 4542c7ed5fc6d8cb2495d322b4f06d802d7292cc. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97715 Cc: "12.0 13.0" --- s