Re: [Mesa-dev] [PATCH] i965: do not emit empty sampler state

2018-08-07 Thread Erik Faye-Lund
On 06. aug. 2018 16:15, Lionel Landwerlin wrote: Hey Erik, I don't think this is right, because by not filling out_offset, you're leaving it at 0 which makes the entry in the binding table point to a dynamic state base address. I would emit the null surface instead. Hmm, good point. I'll r

Re: [Mesa-dev] [PATCH] i965: do not emit empty sampler state

2018-08-06 Thread Lionel Landwerlin
Hey Erik, I don't think this is right, because by not filling out_offset, you're leaving it at 0 which makes the entry in the binding table point to a dynamic state base address. I would emit the null surface instead. - Lionel On 06/08/18 14:27, Erik Faye-Lund wrote: If called with an empty

[Mesa-dev] [PATCH] i965: do not emit empty sampler state

2018-08-06 Thread Erik Faye-Lund
If called with an empty size, brw_emit_buffer_surface_state asserts. And since doing a zero-size upload is really just a lot of work for no gain, let's just avoid the call in the first place. Signed-off-by: Erik Faye-Lund --- This fixes an assert that triggers for me when running dEQP-GLES31.func