Re: [Mesa-dev] [PATCH] i965: Stop looking at NewDriverState when emitting 3DSTATE_URB

2017-08-18 Thread Kenneth Graunke
On Friday, August 18, 2017 4:21:39 PM PDT Jason Ekstrand wrote: > Looking at NewDriverState is not safe in general. The state atom system > is set up to ensure that new bits that get added to NewDriverState get > accumulated into the set of bits used when emitting atoms but it doesn't > go the oth

[Mesa-dev] [PATCH] i965: Stop looking at NewDriverState when emitting 3DSTATE_URB

2017-08-18 Thread Jason Ekstrand
Looking at NewDriverState is not safe in general. The state atom system is set up to ensure that new bits that get added to NewDriverState get accumulated into the set of bits used when emitting atoms but it doesn't go the other way. If we read NewDriverState, we may not get the full picture beca