Re: [Mesa-dev] [PATCH] i965: Safely iterate the predecessors of the end block.

2016-08-24 Thread Kenneth Graunke
On Thursday, August 25, 2016 1:50:01 AM PDT Connor Abbott wrote: [snip] > I think we need to use NIR_VLA here to make MSVC happy. Otherwise, > > Reviewed-by: Connor Abbott Nope - this is in i965, it isn't built with MSVC :) signature.asc Description: This is a digitally signed message part. __

Re: [Mesa-dev] [PATCH] i965: Safely iterate the predecessors of the end block.

2016-08-24 Thread Connor Abbott
On Thu, Aug 25, 2016 at 1:25 AM, Kenneth Graunke wrote: > We want to insert code in each of the predecessors of the end block. > This code includes a nir_if, which would split the block, altering > the set. To avoid that, I emitted a dead constant at the end of each > block before splitting it, s

[Mesa-dev] [PATCH] i965: Safely iterate the predecessors of the end block.

2016-08-24 Thread Kenneth Graunke
We want to insert code in each of the predecessors of the end block. This code includes a nir_if, which would split the block, altering the set. To avoid that, I emitted a dead constant at the end of each block before splitting it, so that the set of predecessors remained unchanged. This was admi