Re: [Mesa-dev] [PATCH] i965: Remove clearing of bo->map_gtt after failure

2017-07-01 Thread Kenneth Graunke
On Saturday, July 1, 2017 3:14:00 AM PDT Chris Wilson wrote: > With the conversion to storing the result of drm_mmap to a local and not > directly to bo->map_gtt itself, we no longer should clear bo->map_gtt. > In the best the operation is redundant as we know bo->map_gtt to already > be NULL, but

[Mesa-dev] [PATCH] i965: Remove clearing of bo->map_gtt after failure

2017-07-01 Thread Chris Wilson
With the conversion to storing the result of drm_mmap to a local and not directly to bo->map_gtt itself, we no longer should clear bo->map_gtt. In the best the operation is redundant as we know bo->map_gtt to already be NULL, but in the worst case we overwrite a concurrent thread that successfully