Re: [Mesa-dev] [PATCH] i965: Improve conditional rendering in fallback paths.

2017-06-01 Thread Jason Ekstrand
I'll freely admit that I don't know this code very well and I don't 100% understand what's going on. But I think my 60% understanding of the old code bumped to 80% with your cleanup so that's a good thing. :-) I left a couple trivial comments below. Reviewed-by: Jason Ekstrand On Thu, Mar 2, 2

Re: [Mesa-dev] [PATCH] i965: Improve conditional rendering in fallback paths.

2017-03-08 Thread Kenneth Graunke
On Thursday, March 2, 2017 12:24:07 AM PST Chris Wilson wrote: > On Thu, Mar 02, 2017 at 12:06:00AM -0800, Kenneth Graunke wrote: > > We need to fall back in a couple of cases: > > - Sandybridge (it just doesn't do this in hardware) > > - Occlusion queries on Gen7-7.5 with command parser version <

Re: [Mesa-dev] [PATCH] i965: Improve conditional rendering in fallback paths.

2017-03-02 Thread Chris Wilson
On Thu, Mar 02, 2017 at 12:06:00AM -0800, Kenneth Graunke wrote: > We need to fall back in a couple of cases: > - Sandybridge (it just doesn't do this in hardware) > - Occlusion queries on Gen7-7.5 with command parser version < 2 > - Transform feedback overflow queries on Gen7, or on Gen7.5 with >

[Mesa-dev] [PATCH] i965: Improve conditional rendering in fallback paths.

2017-03-02 Thread Kenneth Graunke
We need to fall back in a couple of cases: - Sandybridge (it just doesn't do this in hardware) - Occlusion queries on Gen7-7.5 with command parser version < 2 - Transform feedback overflow queries on Gen7, or on Gen7.5 with command parser version < 7 In these cases, we printed a perf_debug messa