Re: [Mesa-dev] [PATCH] i965: Fix src0 vs src1 typo

2017-10-12 Thread Matt Turner
On Tue, Oct 10, 2017 at 4:43 AM, Eero Tamminen wrote: > Hi, > > On 03.10.2017 08:20, Matt Turner wrote: >> >> A typo caused us to copy src0's reg file to src1 rather than reading >> src1's as intended. This caused us to fail to compact instructions like >> >> mov(8) g4<1>D0D

Re: [Mesa-dev] [PATCH] i965: Fix src0 vs src1 typo

2017-10-10 Thread Eero Tamminen
Hi, On 03.10.2017 08:20, Matt Turner wrote: A typo caused us to copy src0's reg file to src1 rather than reading src1's as intended. This caused us to fail to compact instructions like mov(8) g4<1>D0D { align1 1Q }; because src1 was set to immediate rather than architect

Re: [Mesa-dev] [PATCH] i965: Fix src0 vs src1 typo

2017-10-02 Thread Kenneth Graunke
On Monday, October 2, 2017 10:20:00 PM PDT Matt Turner wrote: > A typo caused us to copy src0's reg file to src1 rather than reading > src1's as intended. This caused us to fail to compact instructions like > >mov(8) g4<1>D0D { align1 1Q }; > > because src1 was set to immed

[Mesa-dev] [PATCH] i965: Fix src0 vs src1 typo

2017-10-02 Thread Matt Turner
A typo caused us to copy src0's reg file to src1 rather than reading src1's as intended. This caused us to fail to compact instructions like mov(8) g4<1>D0D { align1 1Q }; because src1 was set to immediate rather than architecture file. Fixing this reenables compaction (afte