Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2018-02-14 Thread Kenneth Graunke
On Saturday, February 3, 2018 1:58:58 PM PST Jordan Justen wrote: > Signed-off-by: Jordan Justen > Reviewed-by: Timothy Arceri > --- > docs/relnotes/18.1.0.html | 1 + > src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 --- > 2 files changed, 1 insertion(+), 3 deletions(-) > > di

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2018-02-05 Thread Jason Ekstrand
On Sat, Feb 3, 2018 at 2:58 PM, Jordan Justen wrote: > On 2018-02-03 14:24:06, Jason Ekstrand wrote: > > On February 3, 2018 13:59:40 Jordan Justen > wrote: > > > > > Signed-off-by: Jordan Justen > > > Reviewed-by: Timothy Arceri > > > --- > > > docs/relnotes/18.1.0.html | 1

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2018-02-04 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 02/03/2018 11:58 PM, Jordan Justen wrote: Signed-off-by: Jordan Justen Reviewed-by: Timothy Arceri --- docs/relnotes/18.1.0.html | 1 + src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff -

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2018-02-03 Thread Jordan Justen
On 2018-02-03 14:24:06, Jason Ekstrand wrote: > On February 3, 2018 13:59:40 Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > Reviewed-by: Timothy Arceri > > --- > > docs/relnotes/18.1.0.html | 1 + > > src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 --- > > 2 files

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2018-02-03 Thread Jason Ekstrand
On February 3, 2018 13:59:40 Jordan Justen wrote: Signed-off-by: Jordan Justen Reviewed-by: Timothy Arceri --- docs/relnotes/18.1.0.html | 1 + src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/relnotes/18.

[Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2018-02-03 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Timothy Arceri --- docs/relnotes/18.1.0.html | 1 + src/mesa/drivers/dri/i965/brw_disk_cache.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/relnotes/18.1.0.html b/docs/relnotes/18.1.0.html index b8a0cd0d02c

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Kenneth Graunke
On Thursday, December 7, 2017 9:57:48 AM PST Matt Turner wrote: [snip] > But the entire API boils down to a comparatively small set of > non-orthogonal state. The configuration of those nobs seems to me like > the place things are most likely to break. I do like Matt's idea of adding Piglit tests

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Jordan Justen
On 2017-12-07 09:57:48, Matt Turner wrote: > On Tue, Dec 5, 2017 at 3:40 PM, Jordan Justen > wrote: > > On 2017-12-05 14:49:28, Mark Janes wrote: > >> Jordan Justen writes: > >> > On 2017-12-05 09:13:11, Mark Janes wrote: > >> >> Adding a dimension to the test matrix has high cost, especially wh

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Timothy Arceri
On 08/12/17 04:57, Matt Turner wrote: On Tue, Dec 5, 2017 at 3:40 PM, Jordan Justen wrote: On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen writes: On 2017-11-08 17:26:47, Timothy Arceri wrote: Reviewed-by: Timothy

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-07 Thread Matt Turner
On Tue, Dec 5, 2017 at 3:40 PM, Jordan Justen wrote: > On 2017-12-05 14:49:28, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-12-05 09:13:11, Mark Janes wrote: >> >> Jordan Justen writes: >> >> >> >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> >> >> Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Jordan Justen
On 2017-12-05 18:30:30, Mark Janes wrote: > Timothy Arceri writes: > > > On 06/12/17 12:04, Mark Janes wrote: > >> Jordan Justen writes: > >> > >>> On 2017-12-05 14:49:28, Mark Janes wrote: > Jordan Justen writes: > > It could be interesting to define a MESA extension to control or qu

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Mark Janes
Timothy Arceri writes: > On 06/12/17 12:04, Mark Janes wrote: >> Jordan Justen writes: >> >>> On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: > On 2017-12-05 09:13:11, Mark Janes wrote: >> Jordan Justen writes: >> >>> On 2017-11-08 17:26:47, Timothy A

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Timothy Arceri
On 06/12/17 12:04, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 14:49:28, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen writes: On 2017-11-08 17:26:47, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Mark may want to consi

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Mark Janes
Jordan Justen writes: > On 2017-12-05 14:49:28, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-12-05 09:13:11, Mark Janes wrote: >> >> Jordan Justen writes: >> >> >> >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> >> >> Reviewed-by: Timothy Arceri >> >> >> >> >> >> Mark ma

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Jordan Justen
On 2017-12-05 14:49:28, Mark Janes wrote: > Jordan Justen writes: > > > On 2017-12-05 09:13:11, Mark Janes wrote: > >> Jordan Justen writes: > >> > >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: > >> >> Reviewed-by: Timothy Arceri > >> >> > >> >> Mark may want to consider adding some of t

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Timothy Arceri
On 06/12/17 09:49, Mark Janes wrote: Jordan Justen writes: On 2017-12-05 09:13:11, Mark Janes wrote: Jordan Justen writes: On 2017-11-08 17:26:47, Timothy Arceri wrote: Reviewed-by: Timothy Arceri Mark may want to consider adding some of the once a day type CI runs for this. For example

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Mark Janes
Jordan Justen writes: > On 2017-12-05 09:13:11, Mark Janes wrote: >> Jordan Justen writes: >> >> > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> >> Reviewed-by: Timothy Arceri >> >> >> >> Mark may want to consider adding some of the once a day type CI runs for >> >> this. For example runn

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Jordan Justen
On 2017-12-05 09:13:11, Mark Janes wrote: > Jordan Justen writes: > > > On 2017-11-08 17:26:47, Timothy Arceri wrote: > >> Reviewed-by: Timothy Arceri > >> > >> Mark may want to consider adding some of the once a day type CI runs for > >> this. For example running the test suite for two consec

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-12-05 Thread Mark Janes
Jordan Justen writes: > On 2017-11-08 17:26:47, Timothy Arceri wrote: >> Reviewed-by: Timothy Arceri >> >> Mark may want to consider adding some of the once a day type CI runs for >> this. For example running the test suite for two consecutive runs on the >> same build so that the second run

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-11-08 Thread Jordan Justen
On 2017-11-08 17:26:47, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > Mark may want to consider adding some of the once a day type CI runs for > this. For example running the test suite for two consecutive runs on the > same build so that the second run uses the shader cache and also

Re: [Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-11-08 Thread Timothy Arceri
Reviewed-by: Timothy Arceri Mark may want to consider adding some of the once a day type CI runs for this. For example running the test suite for two consecutive runs on the same build so that the second run uses the shader cache and also a second run the uses MESA_GLSL=cache_fb to force test

[Mesa-dev] [PATCH] i965: Enable disk shader cache by default

2017-11-08 Thread Jordan Justen
f9d5a7add42af5a2e4410526d1480a08f41317ae along with a16dc04ad51c32e5c7d136e4dd6273d983385d3f appears to have fixed the one known regression with shader cache. (Deus Ex instability.) We should enable the shader cache by default to stabilize it before the next major Mesa release. Signed-off-by: Jor