Re: [Mesa-dev] [PATCH] i965: Emit better code for ir_unop_sign.

2013-12-02 Thread Chris Forbes
Other than that, Reviewed-by: Chris Forbes On Tue, Dec 3, 2013 at 3:45 PM, Chris Forbes wrote: > Where you have the magic 0x3f80u, could you add a comment: > > /* 1.0f */ > > The bit pattern is well-known, but only immediately obvious on a good day :) > > On Tue, Dec 3, 2013 at 2:03 PM, Ken

Re: [Mesa-dev] [PATCH] i965: Emit better code for ir_unop_sign.

2013-12-02 Thread Chris Forbes
Where you have the magic 0x3f80u, could you add a comment: /* 1.0f */ The bit pattern is well-known, but only immediately obvious on a good day :) On Tue, Dec 3, 2013 at 2:03 PM, Kenneth Graunke wrote: > On 12/02/2013 01:46 PM, Matt Turner wrote: >> total instructions in shared programs: 15

Re: [Mesa-dev] [PATCH] i965: Emit better code for ir_unop_sign.

2013-12-02 Thread Kenneth Graunke
On 12/02/2013 01:46 PM, Matt Turner wrote: > total instructions in shared programs: 1519751 -> 1519442 (-0.02%) > instructions in affected programs: 10154 -> 9845 (-3.04%) > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23 +++ > src/mesa/drivers/dri/i965/brw_vec4_

Re: [Mesa-dev] [PATCH] i965: Emit better code for ir_unop_sign.

2013-12-02 Thread Paul Berry
On 2 December 2013 13:46, Matt Turner wrote: > total instructions in shared programs: 1519751 -> 1519442 (-0.02%) > instructions in affected programs: 10154 -> 9845 (-3.04%) > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23 > +++ > src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH] i965: Emit better code for ir_unop_sign.

2013-12-02 Thread Matt Turner
total instructions in shared programs: 1519751 -> 1519442 (-0.02%) instructions in affected programs: 10154 -> 9845 (-3.04%) --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23 +++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 23 --- 2 files cha