On Thu, Apr 23, 2015 at 10:12 PM, Jordan Justen
wrote:
> On 2015-04-23 12:28:00, Ilia Mirkin wrote:
>> On Thu, Apr 23, 2015 at 3:24 PM, Jordan Justen
>> wrote:
>> >> > +#define DEBUG_SPILL (1l << 31)
>> >>
>> >> That seems awkward... did you mean 1U? FWIW mesa's not at all careful
>
On 2015-04-23 12:28:00, Ilia Mirkin wrote:
> On Thu, Apr 23, 2015 at 3:24 PM, Jordan Justen
> wrote:
> >> > +#define DEBUG_SPILL (1l << 31)
> >>
> >> That seems awkward... did you mean 1U? FWIW mesa's not at all careful
> >> about that...
> >
> > Yeah, I agree. 1l is awkward.
> >
> >
On Thu, Apr 23, 2015 at 3:24 PM, Jordan Justen
wrote:
>> > +#define DEBUG_SPILL (1l << 31)
>>
>> That seems awkward... did you mean 1U? FWIW mesa's not at all careful
>> about that...
>
> Yeah, I agree. 1l is awkward.
>
> But I think 1U is just unsigned. I don't think that is guarant
On Thu, Apr 23, 2015 at 3:20 PM, Jason Ekstrand wrote:
>
> On Apr 23, 2015 12:19 PM, "Neil Roberts" wrote:
>>
>> Ilia Mirkin writes:
>>
>> > That seems awkward... did you mean 1U? FWIW mesa's not at all careful
>> > about that...
>>
>> Or maybe even UINT64_C(1). 1l would still be 32-bit on 32-bi
On 2015-04-23 12:01:41, Ilia Mirkin wrote:
> On Thu, Apr 23, 2015 at 2:50 PM, Jason Ekstrand wrote:
> > diff --git a/src/mesa/drivers/dri/i965/intel_debug.h
> > b/src/mesa/drivers/dri/i965/intel_debug.h
> > index 807ad98..e5af998 100644
> > --- a/src/mesa/drivers/dri/i965/intel_debug.h
> > +++ b/
On Apr 23, 2015 12:19 PM, "Neil Roberts" wrote:
>
> Ilia Mirkin writes:
>
> > That seems awkward... did you mean 1U? FWIW mesa's not at all careful
> > about that...
>
> Or maybe even UINT64_C(1). 1l would still be 32-bit on 32-bit
> architectures. I guess this is more of a problem for subsequent
Ilia Mirkin writes:
> That seems awkward... did you mean 1U? FWIW mesa's not at all careful
> about that...
Or maybe even UINT64_C(1). 1l would still be 32-bit on 32-bit
architectures. I guess this is more of a problem for subsequent flags
that go over 32-bit.
- Neil
___
On Thu, Apr 23, 2015 at 2:50 PM, Jason Ekstrand wrote:
> diff --git a/src/mesa/drivers/dri/i965/intel_debug.h
> b/src/mesa/drivers/dri/i965/intel_debug.h
> index 807ad98..e5af998 100644
> --- a/src/mesa/drivers/dri/i965/intel_debug.h
> +++ b/src/mesa/drivers/dri/i965/intel_debug.h
> @@ -64,6 +64,
---
src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp | 2 +-
src/mesa/drivers/dri/i965/intel_debug.c | 1 +
src/mesa/drivers/dri/i965/intel_debug.h | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp
b/src/mes
