Re: [Mesa-dev] [PATCH] i965/vec4/nir: Remove all "this->" snippets

2015-09-18 Thread Kenneth Graunke
On Friday, September 18, 2015 10:30:12 AM Eduardo Lima Mitev wrote: > For consistency, either we have all class members dereferenced, or none. > In this case, very few are so lets get rid of all. > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 31 > +++--- > 1 file ch

Re: [Mesa-dev] [PATCH] i965/vec4/nir: Remove all "this->" snippets

2015-09-18 Thread Timothy Arceri
On Fri, 2015-09-18 at 10:30 +0200, Eduardo Lima Mitev wrote: > For consistency, either we have all class members dereferenced, or > none. > In this case, very few are so lets get rid of all. > --- I kind of like seeing this-> but I like consistency more and majority rules so ... Reviewed-by: Timo

[Mesa-dev] [PATCH] i965/vec4/nir: Remove all "this->" snippets

2015-09-18 Thread Eduardo Lima Mitev
For consistency, either we have all class members dereferenced, or none. In this case, very few are so lets get rid of all. --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 31 +++--- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/