Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-13 Thread Ben Widawsky
On Tue, Aug 11, 2015 at 03:04:17PM +0100, Neil Roberts wrote: > Ben Widawsky writes: > > > Either of you opposed to doing it as a follow-on patch? (This failure > > you speak of was the primary goal for removing it). Initially, I tried > > to remove it, but we do still seem to use this logic pre-

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-11 Thread Neil Roberts
Ben Widawsky writes: > Either of you opposed to doing it as a follow-on patch? (This failure > you speak of was the primary goal for removing it). Initially, I tried > to remove it, but we do still seem to use this logic pre-HSW, and so > things got messier than I initially anticipated. Doing a

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Jason Ekstrand
On Mon, Aug 10, 2015 at 9:49 AM, Ben Widawsky wrote: > On Mon, Aug 10, 2015 at 09:09:41AM -0700, Jason Ekstrand wrote: >> On Aug 10, 2015 4:14 AM, "Neil Roberts" wrote: >> > >> > If we go with this patch perhaps it would be good to remove >> > supports_simd16_3src entirely from brw_device_info an

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Ben Widawsky
On Mon, Aug 10, 2015 at 09:09:41AM -0700, Jason Ekstrand wrote: > On Aug 10, 2015 4:14 AM, "Neil Roberts" wrote: > > > > If we go with this patch perhaps it would be good to remove > > supports_simd16_3src entirely from brw_device_info and any code that is > > referring to it in order to avoid car

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Jason Ekstrand
On Aug 10, 2015 4:14 AM, "Neil Roberts" wrote: > > If we go with this patch perhaps it would be good to remove > supports_simd16_3src entirely from brw_device_info and any code that is > referring to it in order to avoid carrying around useless code. > Currently it seems like it would be quite eas

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-10 Thread Neil Roberts
If we go with this patch perhaps it would be good to remove supports_simd16_3src entirely from brw_device_info and any code that is referring to it in order to avoid carrying around useless code. Currently it seems like it would be quite easy to add a new brw_device_info and forget to add supports_

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-09 Thread Ben Widawsky
On Sun, Aug 09, 2015 at 04:29:33PM -0700, Kenneth Graunke wrote: > On Friday, August 07, 2015 01:58:37 PM Ben Widawsky wrote: > > We do not want bug reports from this early stepping of SKL. Few if any were > > ever > > shipped outside of Intel to early enabling partners, and none will be sold. > >

Re: [Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-09 Thread Kenneth Graunke
On Friday, August 07, 2015 01:58:37 PM Ben Widawsky wrote: > We do not want bug reports from this early stepping of SKL. Few if any were > ever > shipped outside of Intel to early enabling partners, and none will be sold. > > There is a functional change here. If you're using new mesa on an old >

[Mesa-dev] [PATCH] i965/skl: Remove early platform support

2015-08-07 Thread Ben Widawsky
We do not want bug reports from this early stepping of SKL. Few if any were ever shipped outside of Intel to early enabling partners, and none will be sold. There is a functional change here. If you're using new mesa on an old kernel/libdrm, the revid will be -1, and we'll use new SKL values inste