Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics (read-only)

2015-02-18 Thread Francisco Jerez
Jordan Justen writes: > An *untested* update for d9cd982d556be560af3bcbcdaf62b6b93eb934a5. > > A similar change was needed for CS to allow the piglit test > tests/spec/arb_compute_shader/execution/simple-barrier-atomics.shader_test > to pass. > > I think the previous change will fix cases that wr

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics (read-only)

2015-02-17 Thread Ben Widawsky
On Tue, Feb 17, 2015 at 11:03:19AM -0800, Jordan Justen wrote: > An *untested* update for d9cd982d556be560af3bcbcdaf62b6b93eb934a5. > > A similar change was needed for CS to allow the piglit test > tests/spec/arb_compute_shader/execution/simple-barrier-atomics.shader_test > to pass. > > I think t

[Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics (read-only)

2015-02-17 Thread Jordan Justen
An *untested* update for d9cd982d556be560af3bcbcdaf62b6b93eb934a5. A similar change was needed for CS to allow the piglit test tests/spec/arb_compute_shader/execution/simple-barrier-atomics.shader_test to pass. I think the previous change will fix cases that write atomics, such as atomicCounterIn

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-17 Thread Kenneth Graunke
On Sunday, February 15, 2015 11:54:55 PM Ben Widawsky wrote: > The short version: we need to set bits in R0.7 which provide a mask to be used > for PS kill samples/pixels. Since the VS has no such concept, we just need to > set all 1. > > The longer version... > Execution for SIMD8 atomics is defi

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-16 Thread Jason Ekstrand
On Mon, Feb 16, 2015 at 10:28 AM, Ben Widawsky wrote: > On Mon, Feb 16, 2015 at 09:24:34AM -0800, Jason Ekstrand wrote: > > On Feb 16, 2015 7:46 AM, "Francisco Jerez" > wrote: > > > > > > Jason Ekstrand writes: > > > > > > > On Feb 15, 2015 11:55 PM, "Ben Widawsky" < > benjamin.widaw...@intel.c

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-16 Thread Ben Widawsky
On Mon, Feb 16, 2015 at 09:24:34AM -0800, Jason Ekstrand wrote: > On Feb 16, 2015 7:46 AM, "Francisco Jerez" wrote: > > > > Jason Ekstrand writes: > > > > > On Feb 15, 2015 11:55 PM, "Ben Widawsky" > > > wrote: > > >> > > >> The short version: we need to set bits in R0.7 which provide a mask to

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-16 Thread Jason Ekstrand
On Feb 16, 2015 7:46 AM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > On Feb 15, 2015 11:55 PM, "Ben Widawsky" > > wrote: > >> > >> The short version: we need to set bits in R0.7 which provide a mask to be > > used > >> for PS kill samples/pixels. Since the VS has no such concept, w

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-16 Thread Francisco Jerez
Jason Ekstrand writes: > On Feb 15, 2015 11:55 PM, "Ben Widawsky" > wrote: >> >> The short version: we need to set bits in R0.7 which provide a mask to be > used >> for PS kill samples/pixels. Since the VS has no such concept, we just > need to >> set all 1. >> >> The longer version... >> Execut

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-16 Thread Jason Ekstrand
On Feb 15, 2015 11:55 PM, "Ben Widawsky" wrote: > > The short version: we need to set bits in R0.7 which provide a mask to be used > for PS kill samples/pixels. Since the VS has no such concept, we just need to > set all 1. > > The longer version... > Execution for SIMD8 atomics is defined as foll

Re: [Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-16 Thread Francisco Jerez
Ben Widawsky writes: > The short version: we need to set bits in R0.7 which provide a mask to be used > for PS kill samples/pixels. Since the VS has no such concept, we just need to > set all 1. > > The longer version... > Execution for SIMD8 atomics is defined as follows: > SIMD8: The low 8 bits

[Mesa-dev] [PATCH] i965/simd8vs: Fix SIMD8 atomics

2015-02-15 Thread Ben Widawsky
The short version: we need to set bits in R0.7 which provide a mask to be used for PS kill samples/pixels. Since the VS has no such concept, we just need to set all 1. The longer version... Execution for SIMD8 atomics is defined as follows: SIMD8: The low 8 bits of the execution mask are ANDed wit