Re: [Mesa-dev] [PATCH] i965/fs: Fix inverted comparison

2015-03-23 Thread Kenneth Graunke
On Monday, March 23, 2015 12:15:17 PM Ian Romanick wrote: > From: Ian Romanick > > Commit b616164 added an optimization of b2f generation of a comparison. > It also included an extra optimization of one of the comparison values > is a constant of zero. The trick was that some value was known to

Re: [Mesa-dev] [PATCH] i965/fs: Fix inverted comparison

2015-03-23 Thread Ian Romanick
Arg. I changed the code and the body of the commit message, but I didn't change the short log. I'll change it to: i965/fs: Always invert predicate of SEL with swapped arguments On 03/23/2015 12:15 PM, Ian Romanick wrote: > From: Ian Romanick > > Commit b616164 added an optimization of b2f gen

[Mesa-dev] [PATCH] i965/fs: Fix inverted comparison

2015-03-23 Thread Ian Romanick
From: Ian Romanick Commit b616164 added an optimization of b2f generation of a comparison. It also included an extra optimization of one of the comparison values is a constant of zero. The trick was that some value was known to be zero, so that value could be used in the SEL instruction instead