Re: [Mesa-dev] [PATCH] i965/fs: Fix 32-bit integer multiplication.

2011-08-16 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/16/2011 11:55 AM, Kenneth Graunke wrote: > On 08/15/2011 10:57 PM, Eric Anholt wrote: >> The MUL opcode does a 16bit * 32bit multiply, and we need to do the >> MACH to get the top 16bit * 32bit added in. >> >> Fixes fs-op-mult-int-*, fs-op-mult-i

Re: [Mesa-dev] [PATCH] i965/fs: Fix 32-bit integer multiplication.

2011-08-16 Thread Eric Anholt
On Tue, 16 Aug 2011 11:55:50 -0700, Kenneth Graunke wrote: > On 08/15/2011 10:57 PM, Eric Anholt wrote: > > The MUL opcode does a 16bit * 32bit multiply, and we need to do the > > MACH to get the top 16bit * 32bit added in. > > > > Fixes fs-op-mult-int-*, fs-op-mult-ivec* > > Sigh. You're righ

Re: [Mesa-dev] [PATCH] i965/fs: Fix 32-bit integer multiplication.

2011-08-16 Thread Kenneth Graunke
On 08/15/2011 10:57 PM, Eric Anholt wrote: > The MUL opcode does a 16bit * 32bit multiply, and we need to do the > MACH to get the top 16bit * 32bit added in. > > Fixes fs-op-mult-int-*, fs-op-mult-ivec* Sigh. You're right, of course...this is straight out of the documentation (aside from droppi

[Mesa-dev] [PATCH] i965/fs: Fix 32-bit integer multiplication.

2011-08-15 Thread Eric Anholt
The MUL opcode does a 16bit * 32bit multiply, and we need to do the MACH to get the top 16bit * 32bit added in. Fixes fs-op-mult-int-*, fs-op-mult-ivec* --- src/mesa/drivers/dri/i965/brw_fs_emit.cpp|5 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 18 +- 2 files c