Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-07 Thread Francisco Jerez
Matt Turner writes: > On Sun, Jul 5, 2015 at 4:45 PM, Francisco Jerez wrote: >> Hi Matt, >> >> Matt Turner writes: >> >>> On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez >>> wrote: Heh, I happened to come across this comment yesterday while looking for the remaining no16 calls and w

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-06 Thread Matt Turner
On Sun, Jul 5, 2015 at 4:45 PM, Francisco Jerez wrote: > Hi Matt, > > Matt Turner writes: > >> On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez >> wrote: >>> Heh, I happened to come across this comment yesterday while looking for >>> the remaining no16 calls and wondered why on earth it couldn't

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-05 Thread Kenneth Graunke
On Monday, July 06, 2015 02:45:59 AM Francisco Jerez wrote: > Matt Turner writes: > > On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez > > wrote: [snip] > Yeah. I did in fact try to implement uaddCarry last Friday without > using the accumulator by doing something like: > > | CMP.o tmp, src0, -

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-05 Thread Francisco Jerez
Hi Matt, Matt Turner writes: > On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez wrote: >> Heh, I happened to come across this comment yesterday while looking for >> the remaining no16 calls and wondered why on earth it couldn't do the >> same that the normal interpolation code does. After this

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-05 Thread Matt Turner
On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez wrote: > Heh, I happened to come across this comment yesterday while looking for > the remaining no16 calls and wondered why on earth it couldn't do the > same that the normal interpolation code does. After this patch and a > series coming up that w

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-03 Thread Francisco Jerez
Neil Roberts writes: > There was a comment saying that in SIMD16 mode the pixel interpolator > returns coords interleaved 8 channels at a time and that this requires > extra work to support. However, this interleaved format is exactly > what the PLN instruction requires so I don't think anything

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-02 Thread Chris Forbes
Looks OK to me. I didn't think there was going to be much required to make this work -- is nice that it turned out to be nothing. Reviewed-by: Chris Forbes - Chris On Fri, Jul 3, 2015 at 6:41 AM, Neil Roberts wrote: > There was a comment saying that in SIMD16 mode the pixel interpolator > retu

[Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-02 Thread Neil Roberts
There was a comment saying that in SIMD16 mode the pixel interpolator returns coords interleaved 8 channels at a time and that this requires extra work to support. However, this interleaved format is exactly what the PLN instruction requires so I don't think anything needs to be done to support it