Re: [Mesa-dev] [PATCH] i965/fs: Default all constants to a location of -1

2016-05-10 Thread Kenneth Graunke
On Tuesday, May 10, 2016 1:54:58 PM PDT Jason Ekstrand wrote: > Otherwise constants which aren't live get an undefined constant location. > When we go to set up param and pull_param we end up assigning all unused > uniforms to slot 0. This cases the Vulkan driver to segfault because it > doesn't h

Re: [Mesa-dev] [PATCH] i965/fs: Default all constants to a location of -1

2016-05-10 Thread Mark Janes
Reviewed-by: Mark Janes Jason Ekstrand writes: > Otherwise constants which aren't live get an undefined constant location. > When we go to set up param and pull_param we end up assigning all unused > uniforms to slot 0. This cases the Vulkan driver to segfault because it > doesn't have pull_pa

[Mesa-dev] [PATCH] i965/fs: Default all constants to a location of -1

2016-05-10 Thread Jason Ekstrand
Otherwise constants which aren't live get an undefined constant location. When we go to set up param and pull_param we end up assigning all unused uniforms to slot 0. This cases the Vulkan driver to segfault because it doesn't have pull_param. This fixes bugs in the Vulkan driver introduced in c3