Re: [Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Kenneth Graunke
On Tuesday, May 12, 2015 09:23:38 PM Jordan Justen wrote: > On 2015-05-12 17:55:36, Kenneth Graunke wrote: > > For scalar GS support, we either need to add a third constructor which > > forth, right? > > Did you miss removing the compute constructor prototype from brw_fs.h? > > Reviewed-by: Jord

Re: [Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Jordan Justen
On 2015-05-12 17:55:36, Kenneth Graunke wrote: > For scalar GS support, we either need to add a third constructor which forth, right? Did you miss removing the compute constructor prototype from brw_fs.h? Reviewed-by: Jordan Justen > takes the GS structures, or combine the existing two and pas

Re: [Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Jason Ekstrand
On May 12, 2015 5:56 PM, "Kenneth Graunke" wrote: > > For scalar GS support, we either need to add a third constructor which > takes the GS structures, or combine the existing two and pass the shader > stage. > > Given that they're not significantly different, I opted for the latter. > > Signed-of

[Mesa-dev] [PATCH] i965/fs: Combine the fs_visitor constructors.

2015-05-12 Thread Kenneth Graunke
For scalar GS support, we either need to add a third constructor which takes the GS structures, or combine the existing two and pass the shader stage. Given that they're not significantly different, I opted for the latter. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_cs.cpp