Re: [Mesa-dev] [PATCH] i965/disasm: Properly decode branch_ctrl (gen8+)

2014-11-19 Thread Kenneth Graunke
On Wednesday, November 19, 2014 09:15:32 AM Ben Widawsky wrote: > On Wed, Nov 19, 2014 at 01:28:25AM -0800, Kenneth Graunke wrote: > > On Tuesday, November 18, 2014 12:35:55 PM Ben Widawsky wrote: > > > Add support for decoding the new branch control bit. I saw two things > > > wrong with > > > th

Re: [Mesa-dev] [PATCH] i965/disasm: Properly decode branch_ctrl (gen8+)

2014-11-19 Thread Ben Widawsky
On Wed, Nov 19, 2014 at 01:28:25AM -0800, Kenneth Graunke wrote: > On Tuesday, November 18, 2014 12:35:55 PM Ben Widawsky wrote: > > Add support for decoding the new branch control bit. I saw two things wrong > > with > > the existing code. > > > > 1. It didn't bother trying to decode the bit. >

Re: [Mesa-dev] [PATCH] i965/disasm: Properly decode branch_ctrl (gen8+)

2014-11-19 Thread Kenneth Graunke
On Tuesday, November 18, 2014 12:35:55 PM Ben Widawsky wrote: > Add support for decoding the new branch control bit. I saw two things wrong > with > the existing code. > > 1. It didn't bother trying to decode the bit. > - While we do not *intentionally* emit this bit today, I think it's > inter

Re: [Mesa-dev] [PATCH] i965/disasm: Properly decode branch_ctrl (gen8+)

2014-11-18 Thread Matt Turner
On Tue, Nov 18, 2014 at 12:35 PM, Ben Widawsky wrote: > Add support for decoding the new branch control bit. I saw two things wrong > with > the existing code. > > 1. It didn't bother trying to decode the bit. > - While we do not *intentionally* emit this bit today, I think it's > interesting >

[Mesa-dev] [PATCH] i965/disasm: Properly decode branch_ctrl (gen8+)

2014-11-18 Thread Ben Widawsky
Add support for decoding the new branch control bit. I saw two things wrong with the existing code. 1. It didn't bother trying to decode the bit. - While we do not *intentionally* emit this bit today, I think it's interesting to see if we somehow ended up with the bit set. It may also be usefu