Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

2014-08-08 Thread Kenneth Graunke
On Friday, August 08, 2014 05:05:35 PM Jason Ekstrand wrote: > On Fri, Aug 8, 2014 at 4:58 PM, Kenneth Graunke wrote: > > It's also worth noting in your commit message that this is not actually > > fixing a current bug, but rather preventing a regression once your patches > > that convert atomics t

Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

2014-08-08 Thread Matt Turner
On Fri, Aug 8, 2014 at 4:58 PM, Kenneth Graunke wrote: > On Friday, August 08, 2014 02:42:27 PM Jason Ekstrand wrote: >> In particular, this caused problems where atomics operations were getting >> eliminated. >> >> Signed-off-by: Jason Ekstrand >> --- >> src/mesa/drivers/dri/i965/brw_fs_cse.cpp

Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

2014-08-08 Thread Jason Ekstrand
On Fri, Aug 8, 2014 at 4:58 PM, Kenneth Graunke wrote: > On Friday, August 08, 2014 02:42:27 PM Jason Ekstrand wrote: > > In particular, this caused problems where atomics operations were getting > > eliminated. > > > > Signed-off-by: Jason Ekstrand > > --- > > src/mesa/drivers/dri/i965/brw_fs_

Re: [Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

2014-08-08 Thread Kenneth Graunke
On Friday, August 08, 2014 02:42:27 PM Jason Ekstrand wrote: > In particular, this caused problems where atomics operations were getting > eliminated. > > Signed-off-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- > src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 3 ++

[Mesa-dev] [PATCH] i965/cse: Don't eliminate instructions with side-effects

2014-08-08 Thread Jason Ekstrand
In particular, this caused problems where atomics operations were getting eliminated. Signed-off-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 3 ++- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/