Re: [Mesa-dev] [PATCH] i915: Fix gen2 texblend setup

2014-06-17 Thread Ville Syrjälä
On Mon, Jun 16, 2014 at 12:22:43PM -0700, Ian Romanick wrote: > Yeah, that looks right. > > Reviewed-by: Ian Romanick > > Did you notice if other drivers have the same off-by-one issue? I didn't spot similar problems elsewhere. > > On 06/16/2014 11:22 AM, ville.syrj...@linux.intel.com wrote:

Re: [Mesa-dev] [PATCH] i915: Fix gen2 texblend setup

2014-06-16 Thread Ian Romanick
Yeah, that looks right. Reviewed-by: Ian Romanick Did you notice if other drivers have the same off-by-one issue? On 06/16/2014 11:22 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Fix an off by one in the texture unit walk during texblend > setup on gen2. This caused the

[Mesa-dev] [PATCH] i915: Fix gen2 texblend setup

2014-06-16 Thread ville . syrjala
From: Ville Syrjälä Fix an off by one in the texture unit walk during texblend setup on gen2. This caused the last enabled texunit to be skipped resulting in totally messed up texturing. This is a regression introduced here: commit 1ad443ecdd694dd9bf3c4a5050d749fb80db6fa2 Author: Eric Anholt