Re: [Mesa-dev] [PATCH] i915: Don't leave dangling pointer to i915 context on failure

2012-09-28 Thread Ian Romanick
On 09/27/2012 10:33 AM, Eric Anholt wrote: Ian Romanick writes: From: Ian Romanick Otherwise intelDestroyContext would try to dereference the pointer to freed memory. Does DestroyContext get called out of all these error paths? If so, why not just remove our freeing? That's a fair point

Re: [Mesa-dev] [PATCH] i915: Don't leave dangling pointer to i915 context on failure

2012-09-27 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > Otherwise intelDestroyContext would try to dereference the pointer to > freed memory. Does DestroyContext get called out of all these error paths? If so, why not just remove our freeing? pgp2rPWph3DFA.pgp Description: PGP signature __

[Mesa-dev] [PATCH] i915: Don't leave dangling pointer to i915 context on failure

2012-09-26 Thread Ian Romanick
From: Ian Romanick Otherwise intelDestroyContext would try to dereference the pointer to freed memory. NOTE: This is a candidate for the 9.0 branch. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53618 --- src/mesa/drivers/dri/i915/i915_context.c | 14 +