Re: [Mesa-dev] [PATCH] glsl2: Fixed cloning of ir_call error instructions.

2010-09-18 Thread Tilman Sauerbeck
Ian Romanick [2010-09-18 11:18]: > Tilman Sauerbeck wrote: > > Those have the callee field set to the null pointer, so > > calling the public constructor will segfault. > > Do you have a test that triggers this? It would be good to have it in > piglt. I found the bug when I put a vertex shader i

Re: [Mesa-dev] [PATCH] glsl2: Fixed cloning of ir_call error instructions.

2010-09-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tilman Sauerbeck wrote: > Those have the callee field set to the null pointer, so > calling the public constructor will segfault. Do you have a test that triggers this? It would be good to have it in piglt. > Signed-off-by: Tilman Sauerbeck > --- >

Re: [Mesa-dev] [PATCH] glsl2: Fixed cloning of ir_call error instructions.

2010-09-18 Thread Kenneth Graunke
Good catch - thanks! Applied. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl2: Fixed cloning of ir_call error instructions.

2010-09-17 Thread Tilman Sauerbeck
Those have the callee field set to the null pointer, so calling the public constructor will segfault. Signed-off-by: Tilman Sauerbeck --- src/glsl/ir_clone.cpp |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp index aa84cf0..