Re: [Mesa-dev] [PATCH] glsl-compiler: ast: Precise locations positions.

2014-02-05 Thread Sir Anthony
Thanks for you response. First three changes pursued one purpose and meaningless without each other, but glcpp changes can be separated from it. I think, glsl_parser.yy may be separated too, because it have a lot of alteration. I'll do it today. > Or did you mean just that it computed location i

Re: [Mesa-dev] [PATCH] glsl-compiler: ast: Precise locations positions.

2014-02-04 Thread Carl Worth
Sir Anthony writes: > 1. Change locations setup in glsl_parser.yy from yylloc to appropriate token > locations. > 2. Addition of two fields in ast_node location to hold end position of token. > 3. Addition of ast_node method to setup range locations (for aggregate > tokens). > 4. Fix for glcpp-l

[Mesa-dev] [PATCH] glsl-compiler: ast: Precise locations positions.

2014-02-03 Thread Sir Anthony
1. Change locations setup in glsl_parser.yy from yylloc to appropriate token locations. 2. Addition of two fields in ast_node location to hold end position of token. 3. Addition of ast_node method to setup range locations (for aggregate tokens). 4. Fix for glcpp-lex.l. It handled spaces wrong and

[Mesa-dev] [PATCH] glsl-compiler: ast: Precise locations positions.

2014-02-03 Thread Sir Anthony
I'm using mesa glsl-compiler as backend for glsl-debugger interface with heavy use of locations for graphical representation. Locations proposed by original parser is wrong in most cases, because it uses yylloc for all bison rules. This patch includes: 1. Change locations setup in glsl_parser.yy