Re: [Mesa-dev] [PATCH] glsl: work around MinGW 7.x compiler bug

2019-05-02 Thread Eric Engestrom
On 2019-05-01 at 21:35, Brian Paul wrote: > I'm not sure what triggered this, but building with > scons platform=windows toolchain=crossmingw machine=x86 build=profile > with MinGW g++ 7.3 or 7.4 causes an internal compiler error. > > We can work around it by forcing -O1 optimization. > --- > sr

Re: [Mesa-dev] [PATCH] glsl: work around MinGW 7.x compiler bug

2019-05-01 Thread Neha Bhende
LGTM Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Wednesday, May 1, 2019 1:28 PM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Jose Fonseca; Charmaine Lee Subject: [PATCH] glsl: work around MinGW 7.x compiler bug I'm not sure wha

Re: [Mesa-dev] [PATCH] glsl: work around MinGW 7.x compiler bug

2019-05-01 Thread Jose Fonseca
Looks good to me. Reviewed-by: Jose Fonseca From: Brian Paul Sent: Wednesday, May 1, 2019 21:28 To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Jose Fonseca; Charmaine Lee Subject: [PATCH] glsl: work around MinGW 7.x compiler bug I'm not sure what triggere

[Mesa-dev] [PATCH] glsl: work around MinGW 7.x compiler bug

2019-05-01 Thread Brian Paul
I'm not sure what triggered this, but building with scons platform=windows toolchain=crossmingw machine=x86 build=profile with MinGW g++ 7.3 or 7.4 causes an internal compiler error. We can work around it by forcing -O1 optimization. --- src/compiler/glsl/builtin_variables.cpp | 15 ++