Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-03-01 Thread Samuel Pitoiset
Mark, could you try "[PATCH] glsl: fix subroutine mismatch between declarations/definitions" ? It fixes the piglit regression on my side. On 03/01/2017 08:36 PM, Mark Janes wrote: This patch breaks gl45-cts.shader_subroutine.static_subroutine_call. It also breaks piglit.spec.arb_shader_subrou

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-03-01 Thread Samuel Pitoiset
Thanks for reporting this. I will investigate. On 03/01/2017 08:36 PM, Mark Janes wrote: This patch breaks gl45-cts.shader_subroutine.static_subroutine_call. It also breaks piglit.spec.arb_shader_subroutine.compiler.direct-call_vert: Failed to compile vertex shader piglit/tests/spec/arb_shade

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-03-01 Thread Mark Janes
This patch breaks gl45-cts.shader_subroutine.static_subroutine_call. It also breaks piglit.spec.arb_shader_subroutine.compiler.direct-call_vert: Failed to compile vertex shader piglit/tests/spec/arb_shader_subroutine/compiler/direct-call.vert: 0:26(2): error: subroutine name cannot be a constru

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-28 Thread Samuel Pitoiset
On 03/01/2017 12:04 AM, Timothy Arceri wrote: On 01/03/17 03:57, Samuel Pitoiset wrote: On 02/26/2017 10:19 PM, Timothy Arceri wrote: On 25/02/17 22:15, Samuel Pitoiset wrote: This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-28 Thread Timothy Arceri
On 01/03/17 03:57, Samuel Pitoiset wrote: On 02/26/2017 10:19 PM, Timothy Arceri wrote: On 25/02/17 22:15, Samuel Pitoiset wrote: This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the flags.q struct which is nice because arb_bindles

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-28 Thread Samuel Pitoiset
On 02/26/2017 10:19 PM, Timothy Arceri wrote: On 25/02/17 22:15, Samuel Pitoiset wrote: This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the flags.q struct which is nice because arb_bindless_texture will need 4 bits for the new layo

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-26 Thread Timothy Arceri
On 25/02/17 22:15, Samuel Pitoiset wrote: This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the flags.q struct which is nice because arb_bindless_texture will need 4 bits for the new layout qualifiers. No piglit regressions found (incl

[Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-25 Thread Samuel Pitoiset
This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the flags.q struct which is nice because arb_bindless_texture will need 4 bits for the new layout qualifiers. No piglit regressions found (including compiler tests) with "-t subroutine". S