Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

2016-09-12 Thread Marek Olšák
On Mon, Sep 12, 2016 at 4:05 PM, Connor Abbott wrote: > Since demoted inputs become global variables, wouldn't it be more > efficient to simply turn it into a straight assignment? Then the > backend wouldn't have to initialize it to a constant (since it would > be undefined). Maybe, but there are

Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

2016-09-12 Thread Connor Abbott
Since demoted inputs become global variables, wouldn't it be more efficient to simply turn it into a straight assignment? Then the backend wouldn't have to initialize it to a constant (since it would be undefined). On Fri, Sep 9, 2016 at 10:06 AM, Marek Olšák wrote: > From: Marek Olšák > > This

Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

2016-09-12 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 09.09.2016 16:06, Marek Olšák wrote: From: Marek Olšák This fixes 8 fs-interpolateat* piglit crashes on radeonsi, because it can't handle non-input operands in interpolateAt*. --- src/compiler/glsl/link_varyings.cpp | 5 + src/compiler/glsl/opt_algebraic.c

[Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

2016-09-09 Thread Marek Olšák
From: Marek Olšák This fixes 8 fs-interpolateat* piglit crashes on radeonsi, because it can't handle non-input operands in interpolateAt*. --- src/compiler/glsl/link_varyings.cpp | 5 + src/compiler/glsl/opt_algebraic.cpp | 10 ++ 2 files changed, 15 insertions(+) diff --git a/src/