Re: [Mesa-dev] [PATCH] glsl: prevent qualifiers modification of predeclared variables

2018-10-09 Thread Ian Romanick
On 10/09/2018 06:52 AM, andrey simiklit wrote: > Hello, > > Please find my comments below: > > On Sat, Oct 6, 2018 at 1:07 AM Ian Romanick > wrote: > > On 10/05/2018 03:02 PM, Ian Romanick wrote: > > On 10/04/2018 07:08 AM, asimiklit.w...@gmail.com >

Re: [Mesa-dev] [PATCH] glsl: prevent qualifiers modification of predeclared variables

2018-10-09 Thread andrey simiklit
Hello, Please find my comments below: On Sat, Oct 6, 2018 at 1:07 AM Ian Romanick wrote: > On 10/05/2018 03:02 PM, Ian Romanick wrote: > > On 10/04/2018 07:08 AM, asimiklit.w...@gmail.com wrote: > >> From: Andrii Simiklit > >> > >> GLSL 3.7 (Identifiers): > >> "However, as noted in the specifi

Re: [Mesa-dev] [PATCH] glsl: prevent qualifiers modification of predeclared variables

2018-10-05 Thread Ian Romanick
On 10/05/2018 03:02 PM, Ian Romanick wrote: > On 10/04/2018 07:08 AM, asimiklit.w...@gmail.com wrote: >> From: Andrii Simiklit >> >> GLSL 3.7 (Identifiers): >> "However, as noted in the specification, there are some cases where >> previously declared variables can be redeclared to change or add so

Re: [Mesa-dev] [PATCH] glsl: prevent qualifiers modification of predeclared variables

2018-10-05 Thread Ian Romanick
On 10/04/2018 07:08 AM, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > GLSL 3.7 (Identifiers): > "However, as noted in the specification, there are some cases where > previously declared variables can be redeclared to change or add some > property, and predeclared "gl_" names are all

Re: [Mesa-dev] [PATCH] glsl: prevent qualifiers modification of predeclared variables

2018-10-05 Thread andrey simiklit
Hello, + i...@freedesktop.org and add missing bugzilla link Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108247 Regards, Andrii. On Thu, Oct 4, 2018 at 5:08 PM wrote: > From: Andrii Simiklit > > GLSL 3.7 (Identifiers): > "However, as noted in the specification, there are some cases

[Mesa-dev] [PATCH] glsl: prevent qualifiers modification of predeclared variables

2018-10-04 Thread asimiklit . work
From: Andrii Simiklit GLSL 3.7 (Identifiers): "However, as noted in the specification, there are some cases where previously declared variables can be redeclared to change or add some property, and predeclared "gl_" names are allowed to be redeclared in a shader only for these specific purposes.