Re: [Mesa-dev] [PATCH] glsl: fix variable ordering in the output_read_remover

2012-04-03 Thread Tolga Dalman
Hi Vadim, On 03.04.2012 15:29, Vadim Girlin wrote: > On Mon, 2012-04-02 at 13:19 +0200, Tolga Dalman wrote: >>> +static unsigned >>> +hash_table_var_hash(const void *key) >>> +{ >>> + ir_variable *var = (ir_variable*) key; >> >> Why not use const ir_variable instead ? In that case the cast >> wo

Re: [Mesa-dev] [PATCH] glsl: fix variable ordering in the output_read_remover

2012-04-03 Thread Vadim Girlin
On Mon, 2012-04-02 at 13:19 +0200, Tolga Dalman wrote: > Hi, > > On 31.03.2012 20:23, Vadim Girlin wrote: > > Use the hash of the variable name string instead of the pointer value. > > > > Signed-off-by: Vadim Girlin > > --- > > > > This patch solves the problem for me, afaics. > > Tested with

Re: [Mesa-dev] [PATCH] glsl: fix variable ordering in the output_read_remover

2012-04-02 Thread Tolga Dalman
Hi, On 31.03.2012 20:23, Vadim Girlin wrote: > Use the hash of the variable name string instead of the pointer value. > > Signed-off-by: Vadim Girlin > --- > > This patch solves the problem for me, afaics. > Tested with quick-driver.tests > > src/glsl/lower_output_reads.cpp |9 - >

[Mesa-dev] [PATCH] glsl: fix variable ordering in the output_read_remover

2012-03-31 Thread Vadim Girlin
Use the hash of the variable name string instead of the pointer value. Signed-off-by: Vadim Girlin --- This patch solves the problem for me, afaics. Tested with quick-driver.tests src/glsl/lower_output_reads.cpp |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/s