Re: [Mesa-dev] [PATCH] glsl: fix optimization of discard nested multiple levels

2016-07-26 Thread Kenneth Graunke
On Tuesday, July 26, 2016 10:14:12 AM PDT Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The order of optimizations can lead to the conditional discard optimization > being applied twice to the same discard statement. In this case, we must > ensure that both conditions are applied. > > Bugzill

Re: [Mesa-dev] [PATCH] glsl: fix optimization of discard nested multiple levels

2016-07-26 Thread Tapani Pälli
Reviewed-by: Tapani Pälli I've also tested that combining the conditions makes Piglit test pass. On 07/26/2016 11:14 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle The order of optimizations can lead to the conditional discard optimization being applied twice to the same discard statement. I

[Mesa-dev] [PATCH] glsl: fix optimization of discard nested multiple levels

2016-07-26 Thread Nicolai Hähnle
From: Nicolai Hähnle The order of optimizations can lead to the conditional discard optimization being applied twice to the same discard statement. In this case, we must ensure that both conditions are applied. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96762 Cc: mesa-sta...@lists.fr